Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): timeout static occlusion with traffic light #969

Merged
merged 6 commits into from
Oct 22, 2023

Conversation

soblin
Copy link

@soblin soblin commented Oct 20, 2023

Description

autowarefoundation#5243
autowarefoundation#5264
autowarefoundation#5280
autowarefoundation#5304
autowarefoundation#5332
autowarefoundation#5353

のうち autowarefoundation#5353 (本PRのintersectionのスタック防止に関わる)以外についてはコードやデータ構造の変更だけ残して機能面の変更は削除

Related links

feature PR: https://github.com/tier4/autoware_launch.xx1/pull/678

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…n#5234)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…reas (autowarefoundation#5264)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
autowarefoundation#5304)

* merge attention area lanelets topologically

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* query stop line for each merged detection lanelet

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* first conflicting/attention area

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* ignore expectedToStopBeforeStopLine vehicle

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* ignore expectedToStopBeforeStopLine vehicle

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fix

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Copy link
Collaborator

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@soblin
Copy link
Author

soblin commented Oct 20, 2023

念を押してlsimでテストしきったら僕の方でマージします!

Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin changed the title intersectionのスタック防止 feat(intersection): timeout static occlusion with traffic light Oct 22, 2023
@soblin soblin merged commit ef8799d into beta/v0.10.3 Oct 22, 2023
13 of 16 checks passed
@soblin soblin deleted the hotfix/intersection branch October 22, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants